Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic install custom packages #25021

Merged
merged 8 commits into from
Dec 27, 2024
Merged

Automatic install custom packages #25021

merged 8 commits into from
Dec 27, 2024

Conversation

lucasmrod
Copy link
Member

@lucasmrod lucasmrod commented Dec 26, 2024 •
edited
Loading

#24385

Some docs change here: #25026.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

@lucasmrod lucasmrod requested a review from a team as a code owner December 26, 2024 18:16
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.65680% with 31 lines in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (38fcc30) to head (e5e4587).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/software_installers.go 68.08% 10 Missing and 5 partials ⚠️
ee/server/service/software_installers.go 50.00% 9 Missing and 1 partial ⚠️
server/service/software_installers.go 62.50% 2 Missing and 1 partial ⚠️
pkg/automatic_policy/automatic_policy.go 96.96% 2 Missing ⚠️
server/datastore/mysql/queries.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #25021      +/-   ##
==========================================
+ Coverage   63.75%   63.81%   +0.05%     
==========================================
  Files        1610     1611       +1     
  Lines      153169   153387     +218     
  Branches     3962     3962              
==========================================
+ Hits        97654    97881     +227     
+ Misses      47729    47704      -25     
- Partials     7786     7802      +16
Flag Coverage Δ
backend 64.66% <81.65%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iansltx
iansltx reviewed Dec 26, 2024
View reviewed changes
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're 95% of the way there on this one; thanks for putting in the effort (and for cleanup)! Found a few bugs, plus some naming-things feedback; nothing earthshattering.

pkg/automatic_policy/automatic_policy.go Outdated Show resolved Hide resolved
pkg/automatic_policy/automatic_policy.go Outdated Show resolved Hide resolved
pkg/automatic_policy/automatic_policy.go Outdated Show resolved Hide resolved
pkg/automatic_policy/automatic_policy.go Outdated Show resolved Hide resolved
server/datastore/mysql/software_installers.go Outdated Show resolved Hide resolved
server/datastore/mysql/software_installers_test.go Outdated Show resolved Hide resolved
server/datastore/mysql/software_installers_test.go Outdated Show resolved Hide resolved
server/datastore/mysql/software_installers_test.go Outdated Show resolved Hide resolved
server/fleet/software_installer.go Show resolved Hide resolved
tools/custom-package-parser/main.go Show resolved Hide resolved
@lucasmrod lucasmrod requested a review from iansltx December 27, 2024 12:20
@lucasmrod lucasmrod mentioned this pull request Dec 27, 2024
Merged
iansltx
iansltx approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucasmrod lucasmrod merged commit 963cc7e into main Dec 27, 2024
28 checks passed
@lucasmrod lucasmrod deleted the 24385-automatic-install-custom-packages branch December 27, 2024 18:10
lucasmrod added a commit that referenced this pull request Dec 30, 2024
@lucasmrod
Update policy queries for RPM/Debian based systems (#25026)
16d309a 
Docs update for #25021/#24385.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-lisica marko-lisica marko-lisica approved these changes

@iansltx iansltx iansltx approved these changes

Assignees

@iansltx iansltx

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasmrod @iansltx @marko-lisica